infra/helper: pass the right arguments to docker_run in reproduce_impl#14178
Merged
DavidKorczynski merged 2 commits intogoogle:masterfrom Nov 25, 2025
Merged
infra/helper: pass the right arguments to docker_run in reproduce_impl#14178DavidKorczynski merged 2 commits intogoogle:masterfrom
DavidKorczynski merged 2 commits intogoogle:masterfrom
Conversation
Contributor
Author
|
Ping! Is there anything I can do to ease the review of this PR? |
Collaborator
|
overall lgtm! Can you show a difference in output for context? |
Contributor
Author
|
Without the patch: With the patch: This is just a fake vulnerability. Without the PR |
Collaborator
|
/gcbrun skip |
Collaborator
DavidKorczynski
left a comment
There was a problem hiding this comment.
Apologies for the delay here @ret2libc -- thanks for fixing this.
Collaborator
|
Related: #14299 Both lgtm for what it's worth, and I still think we should have this change. |
DavidKorczynski
approved these changes
Nov 25, 2025
This was referenced Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the argument of
docker_run(that isrun_function) isprint_outputand I don't thinkerr_resulthad the same meaning.Without this patch, using
infra/helper.py reproducedoes not produce any output because the docker stdout is not printed.